Skip to content

fix: on Home the focus only points at a launcher, A or a click marks it - #218

Merged
lippdev merged 4 commits into
mainfrom
fix/launcher-selection-tab-switch
Nov 18, 2026
Merged

lippdev merged 4 commits into
mainfrom
fix/launcher-selection-tab-switch

Conversation

@lippdev

@lippdev lippdev commented Nov 18, 2026 •

Copy link
Copy Markdown
Owner

Closes #217.

What

The bug PLEXX-DE reported. On Home the focus picked the launcher (PickFocusedLauncher, on GotFocus). Going to Session with RB/Page Down and back hid the Session page while it held the focus; WinUI then dropped the focus on Home's first tile (Steam), and that picked Steam.

The fix, the owner's call: pointing and marking are two different things. The focus (pad, keyboard, mouse over) only points at a tile; it grows. A or a click marks the launcher (the check and the bar under it), and Play now opens the marked one. PickFocusedLauncher is gone; A and clicks go through the tile's ChooseLaunchTileCommand, unchanged (A also takes the focus down to Play now). The guides already said "A on one picks what opens". The tour's Launchers stop said "move over the one you want", so it changed in the six catalogs and now names the confirm button ({0}; the menu button moved to {1}).

A crash in the same report's log (COMException 0x8001010E at App.xaml.cs:198, ControllerConnectWatcher.OnAdded): RawGameControllerAdded is raised on a Windows.Gaming.Input thread and called CanTrigger, which reads _window.AppWindow, a UI-thread object. It only gets that far with Enter when a controller connects on, so for those users turning the pad on could fail to start the session. The decision, log line and events now run on the dispatcher; CanTrigger is also guarded.

Changelogs (both) and docs/TESTING.md updated (including the 1.7.0 check that said the row picks on focus).

Testing

  • dotnet test: 692 passing. Debug build OK.
  • The owner is testing the debug build on the owner's PC.

🤖 Generated with Claude Code

lippdev and others added 2 commits November 18, 2026 08:30
The focus picks the launcher on Home. Switching back from Session or
System with LB/RB or Page Up/Down, the page that hides dropped the focus
on the first tile (Steam), which picked it. Focus that arrives from
another tab's page, or from nothing, no longer picks.

Also from the log in the same issue: the controller-connect watcher ran
CanTrigger, which reads AppWindow, on a Windows.Gaming.Input thread
(RPC_E_WRONG_THREAD), so "enter when a controller connects" could fail.
The decision now runs on the UI thread.

Fixes #217.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Approach: sound — it distinguishes focus returning from another tab from focus moving within Home, and evaluates the controller auto-start decision on the UI dispatcher before touching the window.

Reviewed changes The review covers the two commits in this PR:

  • Preserve launcher selection: Suppresses focus-based launcher selection when focus returns from Session or System, while retaining normal selection within Home.
  • Handle controller arrival on the UI thread: Dispatches the auto-start decision and related UI/event work, guarding the window-state check.
  • Document and test manually: Adds changelog entries and Windows manual checks for both behaviors.

Pullfrog  | View workflow run | Using gpt-6-luna | 𝕏

The owner's call on #217: pointing (pad focus, mouse over) and marking
are two things. The focus no longer changes the launcher that opens;
A or a click (the tile's command) marks it, as the guides already say.
This replaces the narrower "not when the focus comes from another tab"
rule. The tour's Launchers stop now says so, with the confirm button.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@lippdev lippdev changed the title fix: coming back to Home with LB/RB keeps the chosen launcher fix: on Home the focus only points at a launcher, A or a click marks it Nov 18, 2026

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ No critical issues — one minor documentation inconsistency inline.

Reviewed changes The latest commit changes launcher selection from focus-driven to explicit confirmation and updates the tour copy and manual checks.

  • Separated focus and selection: Focus now only highlights a launcher; A or a click marks it, and A moves to Play now when available.
  • Updated guidance: Revised the launcher tour text and added manual checks for the new behavior.

Pullfrog  | Fix all ➔ | Fix 👍s ➔ | View workflow run | Using gpt-6-luna | 𝕏

Comment thread docs/TESTING.md Resolved
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes The latest commit corrects the manual checklist to match the confirmed launcher-selection behavior.

  • Aligned manual checks: Replaced the stale instruction that A or a click opens a launcher directly with the current behavior: it marks the launcher, A moves focus to Play now, and Play now opens it.

Pullfrog  | View workflow run | Using gpt-6-luna | 𝕏

@lippdev
lippdev merged commit 7f72176 into main Nov 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Selection of launcher app gets reverted

1 participant